Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AD manifest for 2.3.1 and 3.0.0 #2739

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Add AD manifest for 2.3.1 and 3.0.0 #2739

merged 2 commits into from
Oct 24, 2022

Conversation

jackiehanyang
Copy link
Contributor

Signed-off-by: Jackie Han [email protected]

Description

Add AD manifest for 2.3.1 and 3.0.0 for this campaign - opensearch-project/opensearch-plugins#142

Issues Resolved

opensearch-project/opensearch-plugins#142

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jackiehanyang jackiehanyang requested a review from a team as a code owner October 14, 2022 21:55
@codecov-commenter
Copy link

Codecov Report

Merging #2739 (b44b706) into main (d523da5) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
- Coverage   94.10%   93.77%   -0.34%     
==========================================
  Files         156      156              
  Lines        4208     4208              
==========================================
- Hits         3960     3946      -14     
- Misses        248      262      +14     
Impacted Files Coverage Δ
src/system/temporary_directory.py 64.44% <0.00%> (-28.89%) ⬇️
src/system/os.py 93.75% <0.00%> (-6.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 3.0, there are some breaking changes in OpenSearch core. Make sure the breaking changes fixed in AD.

@jackiehanyang
Copy link
Contributor Author

For 3.0, there are some breaking changes in OpenSearch core. Make sure the breaking changes fixed in AD.

breaking changes are all fixed for AD. AD CI all passed

@gaiksaya
Copy link
Member

Looks like common-utils build is failing for 3.0.0
Related issue: opensearch-project/common-utils#296

@peterzhuamazon
Copy link
Member

Merging now as it is not related to AD.

@peterzhuamazon peterzhuamazon merged commit 082fe62 into opensearch-project:main Oct 24, 2022
monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants